From ac008f54ea6d1ce3bf7b6ac3b8852106039abf9b Mon Sep 17 00:00:00 2001
From: Zef Hemel <zef@zef.me>
Date: Fri, 30 Sep 2022 16:59:57 +0200
Subject: [PATCH] Fixes #34: adding modal panel and refactored API

---
 .../plugos-silverbullet-syscall/editor.ts     | 77 +++++++++++--------
 packages/plugs/core/debug.ts                  |  5 +-
 packages/web/components/panel.tsx             | 17 ++--
 packages/web/editor.tsx                       | 50 ++++++------
 packages/web/reducer.ts                       | 47 +++--------
 packages/web/styles/main.scss                 | 17 ++++
 packages/web/styles/theme.scss                |  5 ++
 packages/web/syscalls/editor.ts               | 55 ++++++-------
 packages/web/types.ts                         | 42 +++++-----
 9 files changed, 164 insertions(+), 151 deletions(-)

diff --git a/packages/plugos-silverbullet-syscall/editor.ts b/packages/plugos-silverbullet-syscall/editor.ts
index 740731c1..89b6f5ea 100644
--- a/packages/plugos-silverbullet-syscall/editor.ts
+++ b/packages/plugos-silverbullet-syscall/editor.ts
@@ -61,40 +61,17 @@ export function filterBox(
   return syscall("editor.filterBox", label, options, helpText, placeHolder);
 }
 
-export function showRhs(
+export function showPanel(
+  id: "lhs" | "rhs" | "bhs" | "modal",
+  mode: number,
   html: string,
-  script?: string,
-  flex = 1
+  script: string
 ): Promise<void> {
-  return syscall("editor.showRhs", html, script, flex);
+  return syscall("editor.showPanel", id, mode, html, script);
 }
 
-export function hideRhs(): Promise<void> {
-  return syscall("editor.hideRhs");
-}
-
-export function showLhs(
-  html: string,
-  script?: string,
-  flex = 1
-): Promise<void> {
-  return syscall("editor.showLhs", html, script, flex);
-}
-
-export function hideLhs(): Promise<void> {
-  return syscall("editor.hideLhs");
-}
-
-export function showBhs(
-  html: string,
-  script?: string,
-  flex = 1
-): Promise<void> {
-  return syscall("editor.showBhs", html, script, flex);
-}
-
-export function hideBhs(): Promise<void> {
-  return syscall("editor.hideBhs");
+export function hidePanel(id: "lhs" | "rhs" | "bhs" | "modal"): Promise<void> {
+  return syscall("editor.hidePanel", id);
 }
 
 export function insertAtPos(text: string, pos: number): Promise<void> {
@@ -137,3 +114,43 @@ export function prompt(
 export function enableReadOnlyMode(enabled: boolean) {
   return syscall("editor.enableReadOnlyMode", enabled);
 }
+
+// DEPRECATED in favor of showPanel and hidePanel
+
+export function showRhs(
+  html: string,
+  script?: string,
+  flex = 1
+): Promise<void> {
+  return syscall("editor.showRhs", html, script, flex);
+}
+
+export function hideRhs(): Promise<void> {
+  return syscall("editor.hideRhs");
+}
+
+export function showLhs(
+  html: string,
+  script?: string,
+  flex = 1
+): Promise<void> {
+  return syscall("editor.showLhs", html, script, flex);
+}
+
+export function hideLhs(): Promise<void> {
+  return syscall("editor.hideLhs");
+}
+
+export function showBhs(
+  html: string,
+  script?: string,
+  flex = 1
+): Promise<void> {
+  return syscall("editor.showBhs", html, script, flex);
+}
+
+export function hideBhs(): Promise<void> {
+  return syscall("editor.hideBhs");
+}
+
+// End deprecation
diff --git a/packages/plugs/core/debug.ts b/packages/plugs/core/debug.ts
index bb87fac6..6b5e9909 100644
--- a/packages/plugs/core/debug.ts
+++ b/packages/plugs/core/debug.ts
@@ -3,6 +3,7 @@ import {
   getText,
   hideBhs,
   showBhs,
+  showPanel,
 } from "@silverbulletmd/plugos-silverbullet-syscall/editor";
 import { parseMarkdown } from "@silverbulletmd/plugos-silverbullet-syscall/markdown";
 import { getServerLogs } from "@silverbulletmd/plugos-silverbullet-syscall/sandbox";
@@ -19,7 +20,9 @@ export async function showLogsCommand() {
   let clientLogs = await getLogs();
   let serverLogs = await getServerLogs();
 
-  await showBhs(
+  await showPanel(
+    "modal",
+    100,
     `
     <style>
     #client-log-header {
diff --git a/packages/web/components/panel.tsx b/packages/web/components/panel.tsx
index f029a29e..9ed4c096 100644
--- a/packages/web/components/panel.tsx
+++ b/packages/web/components/panel.tsx
@@ -2,16 +2,13 @@ import { useEffect, useRef } from "react";
 // @ts-ignore
 import iframeHtml from "bundle-text:./panel.html";
 import { Editor } from "../editor";
+import { PanelConfig } from "../types";
 
 export function Panel({
-  html,
-  script,
-  flex,
+  config,
   editor,
 }: {
-  html: string;
-  script?: string;
-  flex: number;
+  config: PanelConfig;
   editor: Editor;
 }) {
   const iFrameRef = useRef<HTMLIFrameElement>(null);
@@ -20,8 +17,8 @@ export function Panel({
       if (iFrameRef.current?.contentWindow) {
         iFrameRef.current.contentWindow.postMessage({
           type: "html",
-          html: html,
-          script: script,
+          html: config.html,
+          script: config.script,
         });
       }
     }
@@ -34,7 +31,7 @@ export function Panel({
     return () => {
       iframe.onload = null;
     };
-  }, [html]);
+  }, [config.html, config.script]);
 
   useEffect(() => {
     let messageListener = (evt: any) => {
@@ -54,7 +51,7 @@ export function Panel({
   }, []);
 
   return (
-    <div className="sb-panel" style={{ flex }}>
+    <div className="sb-panel" style={{ flex: config.mode }}>
       <iframe srcDoc={iframeHtml} ref={iFrameRef} />
     </div>
   );
diff --git a/packages/web/editor.tsx b/packages/web/editor.tsx
index bb45e64a..27209213 100644
--- a/packages/web/editor.tsx
+++ b/packages/web/editor.tsx
@@ -61,7 +61,6 @@ import sandboxSyscalls from "@plugos/plugos/syscalls/sandbox";
 import { eventSyscalls } from "@plugos/plugos/syscalls/event";
 import { storeSyscalls } from "./syscalls/store";
 import { inlineImagesPlugin } from "./inline_image";
-import { ConsoleLogger } from "@plugos/plugos/environments/custom_logger";
 import { fulltextSyscalls } from "./syscalls/fulltext";
 
 class PageState {
@@ -801,43 +800,42 @@ export class Editor {
             dispatch({ type: "show-palette" });
           }}
           rhs={
-            !!viewState.showRHS && (
-              <div className="panel" style={{ flex: viewState.showRHS }} />
+            !!viewState.panels.rhs.mode && (
+              <div
+                className="panel"
+                style={{ flex: viewState.panels.rhs.mode }}
+              />
             )
           }
           lhs={
-            !!viewState.showLHS && (
-              <div className="panel" style={{ flex: viewState.showLHS }} />
+            !!viewState.panels.lhs.mode && (
+              <div
+                className="panel"
+                style={{ flex: viewState.panels.lhs.mode }}
+              />
             )
           }
         />
         <div id="sb-main">
-          {!!viewState.showLHS && (
-            <Panel
-              html={viewState.lhsHTML}
-              script={viewState.lhsScript}
-              flex={viewState.showLHS}
-              editor={editor}
-            />
+          {!!viewState.panels.lhs.mode && (
+            <Panel config={viewState.panels.lhs} editor={editor} />
           )}
           <div id="sb-editor" />
-          {!!viewState.showRHS && (
-            <Panel
-              html={viewState.rhsHTML}
-              script={viewState.rhsScript}
-              flex={viewState.showRHS}
-              editor={editor}
-            />
+          {!!viewState.panels.rhs.mode && (
+            <Panel config={viewState.panels.rhs} editor={editor} />
           )}
         </div>
-        {!!viewState.showBHS && (
+        {!!viewState.panels.modal.mode && (
+          <div
+            className="sb-modal"
+            style={{ inset: `${viewState.panels.modal.mode}px` }}
+          >
+            <Panel config={viewState.panels.modal} editor={editor} />
+          </div>
+        )}
+        {!!viewState.panels.bhs.mode && (
           <div className="sb-bhs">
-            <Panel
-              html={viewState.bhsHTML}
-              script={viewState.bhsScript}
-              flex={1}
-              editor={editor}
-            />
+            <Panel config={viewState.panels.bhs} editor={editor} />
           </div>
         )}
       </>
diff --git a/packages/web/reducer.ts b/packages/web/reducer.ts
index 6a9aff2f..df2a1c6c 100644
--- a/packages/web/reducer.ts
+++ b/packages/web/reducer.ts
@@ -102,48 +102,23 @@ export default function reducer(
         ...state,
         notifications: state.notifications.filter((n) => n.id !== action.id),
       };
-    case "show-rhs":
+    case "show-panel":
       return {
         ...state,
-        showRHS: action.flex,
-        rhsHTML: action.html,
-        rhsScript: action.script,
+        panels: {
+          ...state.panels,
+          [action.id]: action.config,
+        },
       };
-    case "hide-rhs":
+    case "hide-panel":
       return {
         ...state,
-        showRHS: 0,
-        rhsHTML: "",
-        rhsScript: undefined,
-      };
-    case "show-lhs":
-      return {
-        ...state,
-        showLHS: action.flex,
-        lhsHTML: action.html,
-        lhsScript: action.script,
-      };
-    case "hide-lhs":
-      return {
-        ...state,
-        showLHS: 0,
-        lhsHTML: "",
-        lhsScript: undefined,
-      };
-    case "show-bhs":
-      return {
-        ...state,
-        showBHS: action.flex,
-        bhsHTML: action.html,
-        bhsScript: action.script,
-      };
-    case "hide-bhs":
-      return {
-        ...state,
-        showBHS: 0,
-        bhsHTML: "",
-        bhsScript: undefined,
+        panels: {
+          ...state.panels,
+          [action.id]: {},
+        },
       };
+
     case "show-filterbox":
       return {
         ...state,
diff --git a/packages/web/styles/main.scss b/packages/web/styles/main.scss
index 4bc7e2d7..2935d6a1 100644
--- a/packages/web/styles/main.scss
+++ b/packages/web/styles/main.scss
@@ -135,3 +135,20 @@
     }
   }
 }
+
+.sb-modal {
+  position: absolute;
+  z-index: 100;
+
+  .sb-panel {
+    height: 100%;
+
+    iframe {
+      border: 0;
+      width: 100%;
+      height: 100%;
+      padding: 0;
+      margin: 0;
+    }
+  }
+}
diff --git a/packages/web/styles/theme.scss b/packages/web/styles/theme.scss
index 853219a8..a642fce0 100644
--- a/packages/web/styles/theme.scss
+++ b/packages/web/styles/theme.scss
@@ -17,6 +17,11 @@
   border-top: rgb(193, 193, 193) 1px solid;
 }
 
+.sb-modal {
+  border: 1px solid #000;
+  background-color: #fff;
+}
+
 .sb-notifications {
   font-family: "iA-Mono";
 }
diff --git a/packages/web/syscalls/editor.ts b/packages/web/syscalls/editor.ts
index 3dbbda63..0fd5d182 100644
--- a/packages/web/syscalls/editor.ts
+++ b/packages/web/syscalls/editor.ts
@@ -27,7 +27,7 @@ function ensureAnchor(expr: any, start: boolean) {
 }
 
 export function editorSyscalls(editor: Editor): SysCallMapping {
-  return {
+  const syscalls: SysCallMapping = {
     "editor.getCurrentPage": (): string => {
       return editor.currentPage!;
     },
@@ -76,44 +76,43 @@ export function editorSyscalls(editor: Editor): SysCallMapping {
     ): Promise<FilterOption | undefined> => {
       return editor.filterBox(label, options, helpText, placeHolder);
     },
-    "editor.showRhs": (ctx, html: string, script: string, flex: number) => {
+    "editor.showPanel": (
+      ctx,
+      id: string,
+      mode: number,
+      html: string,
+      script: string
+    ) => {
       editor.viewDispatch({
-        type: "show-rhs",
-        flex,
-        html,
-        script,
+        type: "show-panel",
+        id: id as any,
+        config: { html, script, mode },
       });
     },
+    "editor.hidePanel": (ctx, id: string) => {
+      editor.viewDispatch({
+        type: "hide-panel",
+        id: id as any,
+      });
+    },
+    // Deprecated in favor of using "hidePanel" and "showPanel"
+    "editor.showRhs": (ctx, html: string, script: string, flex: number) => {
+      syscalls["editor.showPanel"](ctx, "rhs", flex, html, script);
+    },
     "editor.hideRhs": (ctx) => {
-      editor.viewDispatch({
-        type: "hide-rhs",
-      });
+      syscalls["editor.hidePanel"](ctx, "rhs");
     },
     "editor.showLhs": (ctx, html: string, script: string, flex: number) => {
-      editor.viewDispatch({
-        type: "show-lhs",
-        flex,
-        html,
-        script,
-      });
+      syscalls["editor.showPanel"](ctx, "lhs", flex, html, script);
     },
     "editor.hideLhs": (ctx) => {
-      editor.viewDispatch({
-        type: "hide-lhs",
-      });
+      syscalls["editor.hidePanel"](ctx, "lhs");
     },
     "editor.showBhs": (ctx, html: string, script: string, flex: number) => {
-      editor.viewDispatch({
-        type: "show-bhs",
-        flex,
-        html,
-        script,
-      });
+      syscalls["editor.showPanel"](ctx, "bhs", flex, html, script);
     },
     "editor.hideBhs": (ctx) => {
-      editor.viewDispatch({
-        type: "hide-bhs",
-      });
+      syscalls["editor.hidePanel"](ctx, "bhs");
     },
     "editor.insertAtPos": (ctx, text: string, pos: number) => {
       editor.editorView!.dispatch({
@@ -199,4 +198,6 @@ export function editorSyscalls(editor: Editor): SysCallMapping {
       });
     },
   };
+
+  return syscalls;
 }
diff --git a/packages/web/types.ts b/packages/web/types.ts
index 8d305f54..649de5b8 100644
--- a/packages/web/types.ts
+++ b/packages/web/types.ts
@@ -10,6 +10,14 @@ export type Notification = {
 
 type EditorMode = "ro" | "rw";
 
+export type PanelMode = number;
+
+export type PanelConfig = {
+  mode?: PanelMode;
+  html?: string;
+  script?: string;
+};
+
 export type AppViewState = {
   currentPage?: string;
   perm: EditorMode;
@@ -18,15 +26,7 @@ export type AppViewState = {
   showPageNavigator: boolean;
   showCommandPalette: boolean;
   unsavedChanges: boolean;
-  showLHS: number; // 0 = hide, > 0 = flex
-  showRHS: number; // 0 = hide, > 0 = flex
-  showBHS: number;
-  rhsHTML: string;
-  lhsHTML: string;
-  bhsHTML: string;
-  rhsScript?: string;
-  lhsScript?: string;
-  bhsScript?: string;
+  panels: { [key: string]: PanelConfig };
   allPages: Set<PageMeta>;
   commands: Map<string, AppCommand>;
   notifications: Notification[];
@@ -47,12 +47,12 @@ export const initialViewState: AppViewState = {
   showPageNavigator: false,
   showCommandPalette: false,
   unsavedChanges: false,
-  showLHS: 0,
-  showRHS: 0,
-  showBHS: 0,
-  rhsHTML: "",
-  lhsHTML: "",
-  bhsHTML: "",
+  panels: {
+    lhs: {},
+    rhs: {},
+    bhs: {},
+    modal: {},
+  },
   allPages: new Set(),
   commands: new Map(),
   recentCommands: new Map(),
@@ -81,12 +81,12 @@ export type Action =
   | { type: "hide-palette" }
   | { type: "show-notification"; notification: Notification }
   | { type: "dismiss-notification"; id: number }
-  | { type: "show-rhs"; html: string; flex: number; script?: string }
-  | { type: "hide-rhs" }
-  | { type: "show-lhs"; html: string; flex: number; script?: string }
-  | { type: "hide-lhs" }
-  | { type: "show-bhs"; html: string; flex: number; script?: string }
-  | { type: "hide-bhs" }
+  | {
+      type: "show-panel";
+      id: "rhs" | "lhs" | "bhs" | "modal";
+      config: PanelConfig;
+    }
+  | { type: "hide-panel"; id: string }
   | { type: "command-run"; command: string }
   | {
       type: "show-filterbox";