From 9e0925beffbaea1b95b4c07c6a28ca7ca63c299b Mon Sep 17 00:00:00 2001
From: Zef Hemel <zef@zef.me>
Date: Sat, 22 Feb 2025 11:50:44 +0100
Subject: [PATCH] Fix lint issues

---
 deno.json                       | 2 +-
 server/http_server.ts           | 2 +-
 web/components/basic_modals.tsx | 1 +
 web/components/top_bar.tsx      | 7 ++++++-
 4 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/deno.json b/deno.json
index e22da700..1cf95745 100644
--- a/deno.json
+++ b/deno.json
@@ -66,7 +66,7 @@
       "cmd/test/test_space"
     ],
     "rules": {
-      "exclude": ["no-explicit-any", "no-slow-types"]
+      "exclude": ["no-explicit-any", "no-slow-types", "jsx-boolean-value"]
     }
   },
   "fmt": {
diff --git a/server/http_server.ts b/server/http_server.ts
index 51536e5a..b178c1f3 100644
--- a/server/http_server.ts
+++ b/server/http_server.ts
@@ -268,7 +268,7 @@ export class HttpServer {
         }
         c.status(200);
         c.header("Content-type", this.clientAssetBundle.getMimeType(assetName));
-        let data = this.clientAssetBundle.readFileSync(
+        const data = this.clientAssetBundle.readFileSync(
           assetName,
         );
         c.header("Content-length", "" + data.length);
diff --git a/web/components/basic_modals.tsx b/web/components/basic_modals.tsx
index d79cd50f..0d2f466c 100644
--- a/web/components/basic_modals.tsx
+++ b/web/components/basic_modals.tsx
@@ -130,6 +130,7 @@ export function Button({
   return (
     <button
       ref={buttonRef}
+      type="button"
       className={primary ? "sb-button-primary" : "sb-button"}
       onClick={(e) => {
         e.stopPropagation();
diff --git a/web/components/top_bar.tsx b/web/components/top_bar.tsx
index 09d6741f..1040941b 100644
--- a/web/components/top_bar.tsx
+++ b/web/components/top_bar.tsx
@@ -119,6 +119,7 @@ export function TopBar({
               {actionButtons.map((actionButton) => {
                 const button = (
                   <button
+                    type="button"
                     onClick={(e) => {
                       e.preventDefault();
                       e.stopPropagation();
@@ -132,7 +133,11 @@ export function TopBar({
                 );
 
                 return actionButton.href !== undefined
-                  ? <a href={actionButton.href}>{button}</a>
+                  ? (
+                    <a href={actionButton.href} key={actionButton.href}>
+                      {button}
+                    </a>
+                  )
                   : button;
               })}
             </div>