mingzailao
/
mitsuba
mirror of https://github.com/Quartenia/mitsuba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

hslt: verification.cpp: better validation of edge data structures

metadata
johannes hanika 2014-11-03 16:10:26 +01:00 committed by Wenzel Jakob
parent 23efb01b4d
commit cb56d97fcf
1 changed files with 32 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
src/libbidir/verification.cpp
View File

@ -62,6 +62,25 @@ static bool validateValue(const std::string name, Float value, Float cached, std
return valid;
}
static bool validateValue(const std::string name, Vector value, Vector cached, std::ostream &os) {
bool valid = true;
Float err = (cached-value).length();
Float mag = std::max(cached.length(), value.length());
if(std::isnan(err))
valid = false;
else if(mag < MTS_BD_MAXERR && err > MTS_BD_MAXERR) // absolute error threshold
valid = false;
else if(mag > MTS_BD_MAXERR && err/mag > MTS_BD_MAXERR) // relative error threshold
valid = false;
if(!valid)
os << " " << name << " mismatch: cached=" << cached.toString() << ", computed=" << value.toString() << endl;
return valid;
}
bool PathVertex::verify(const Scene *scene, const PathVertex *pred, const PathVertex *succ,
ETransportMode mode, std::ostream &os) const {
if (mode == ERadiance)
@ -151,10 +170,14 @@ bool PathEdge::verify(const Scene *scene, const PathVertex *pred,
bool valid = true;
if (!pred->isSupernode() && !succ->isSupernode()) {
Float refLength = (pred->getPosition()-succ->getPosition()).length();
valid &= validateValue("length", refLength, length, os);
Vector refDireciton = succ->getPosition()-pred->getPosition();
Float refLength = refDireciton.length();
refDireciton /= refLength;
valid &= validateValue("length", refLength, length, os);
valid &= validateValue("d", refDireciton, d, os);
}
valid &= validateValue("weight[ERadiance]", weightE, weight[ERadiance], os);
valid &= validateValue("weight[EImportance]", weightL, weight[EImportance], os);
valid &= validateValue("pdf[ERadiance]", pdfE, pdf[ERadiance], os);
@ -172,7 +195,14 @@ bool Path::verify(const Scene *scene, ETransportMode mode, std::ostream &os) con
oss << "Vertex " << i << ":" << endl;
if (!m_vertices[i]->verify(scene, pred, succ, mode, oss))
valid = false;
if(i > 0 && i < m_edges.size())
{
oss << "Edge " << i << ":" << endl;
if(!m_edges[i-1]->verify(scene, pred, m_vertices[i], mode, oss))
valid = false;
}
}
if (!valid) {
os << "Detected an inconsistency in the path " << endl;
os << toString() << endl;