mingzailao
/
mitsuba
mirror of https://github.com/Quartenia/mitsuba.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fixed an incorrect radiance conversion factor in 'coating' and 'roughcoating' reported by Attila Afra. 

The models now produce the right falloff compared to Monte Carlo
reference renderings with explicitly instantiated layers
metadata
Wenzel Jakob 2015-06-30 11:16:48 +02:00
parent 10d47cef56
commit 9b225443a4
2 changed files with 8 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/bsdfs/coating.cpp
View File

@ -246,12 +246,10 @@ public:
(1/std::abs(Frame::cosTheta(bRecInt.wi)) +
1/std::abs(Frame::cosTheta(bRecInt.wo)))).exp();
if (measure == ESolidAngle) {
/* Solid angle compression & irradiance conversion factors */
if (measure == ESolidAngle)
result *= m_invEta * m_invEta *
Frame::cosTheta(bRec.wi) * Frame::cosTheta(bRec.wo)
/ (Frame::cosTheta(bRecInt.wi) * Frame::cosTheta(bRecInt.wo));
}
Frame::cosTheta(bRec.wo) / Frame::cosTheta(bRecInt.wo);
return result;
}
@ -364,11 +362,9 @@ public:
result *= (1 - R12) * (1 - R21);
if (BSDF::getMeasure(bRec.sampledType) == ESolidAngle) {
/* Solid angle compression & irradiance conversion factors */
result *= Frame::cosTheta(bRec.wi) / Frame::cosTheta(wiPrime);
if (BSDF::getMeasure(bRec.sampledType) == ESolidAngle)
pdf *= m_invEta * m_invEta * Frame::cosTheta(bRec.wo) / Frame::cosTheta(woPrime);
}
return result;
}

6
src/bsdfs/roughcoating.cpp
View File

@ -306,12 +306,10 @@ public:
(1/std::abs(Frame::cosTheta(bRecInt.wi)) +
1/std::abs(Frame::cosTheta(bRecInt.wo)))).exp();
if (measure == ESolidAngle) {
/* Solid angle compression & irradiance conversion factors */
if (measure == ESolidAngle)
nestedResult *= m_invEta * m_invEta *
Frame::cosTheta(bRec.wi) * Frame::cosTheta(bRec.wo)
/ (Frame::cosTheta(bRecInt.wi) * Frame::cosTheta(bRecInt.wo));
}
Frame::cosTheta(bRec.wo) / Frame::cosTheta(bRecInt.wo);
result += nestedResult;
}